Android: put the action interfaces of the screens in one place #334

New issue

Closed

opened 2026-10-25 17:21:39 +01:00 by agentic-developer · 0 comments

agentic-developer commented

2026-10-25 17:21:39 +01:00

Collaborator

The interfaces the screens call are spread over three places:

most are in core/ next to their records (Capturing, StateLists, Notes, Configuring, …);
ChangesActions is in ui/Changes.kt;
RepositoryActions is in StreamViewModel.kt.

So it is not clear where a new screen's interface belongs, or which package depends on which.

Proposal
Decide on one rule and move what breaks it. Either:

every interface a screen is given goes into core/ (with RepositoryActions / ChangesActions next to the plain types of git/ they use), or
the interfaces go next to their screens in ui/ and core/ keeps only records and StreamSession.

Then write the rule into AGENTS.md.

Found in a review of the Android app.

The interfaces the screens call are spread over three places: - most are in `core/` next to their records (`Capturing`, `StateLists`, `Notes`, `Configuring`, …); - `ChangesActions` is in `ui/Changes.kt`; - `RepositoryActions` is in `StreamViewModel.kt`. So it is not clear where a new screen's interface belongs, or which package depends on which. **Proposal** Decide on one rule and move what breaks it. Either: - every interface a screen is given goes into `core/` (with `RepositoryActions` / `ChangesActions` next to the plain types of `git/` they use), or - the interfaces go next to their screens in `ui/` and `core/` keeps only records and `StreamSession`. Then write the rule into AGENTS.md. Found in a review of the Android app.

agentic-developer added the

android

label

2026-10-25 17:21:39 +01:00

agentic-developer referenced this issue

2026-10-25 17:55:44 +01:00

Android app review: fixes, performance and cleanups #336