Android: split StreamViewModel, which implements twelve interfaces #333

New issue

Closed

opened 2026-10-25 17:21:35 +01:00 by agentic-developer · 0 comments

agentic-developer commented

2026-10-25 17:21:35 +01:00

Collaborator

StreamViewModel implements RepositoryActions, Capturing, StreamReading, StateLists, Timesheets, Activities, Overviews, Notes, ChangesActions, Configuring and WorkingTime. Each method mostly forwards to session.value?.x(..., Instant.now()) ?: X.Failed(NO_STREAM), sometimes followed by written(id). App then takes about 13 parameters that are all this same object.

Proposal

Give each concern its own small adapter over Streamd (or over StreamSession plus the clock and RepositoryConnection.written): states, timesheets, activities, notes, configuration, capture.
Hand App one holder of them (for example AppActions) instead of thirteen parameters.
Keep one view model for the lifecycle: the StateFlows and viewModelScope.
Write the "no stream" and "commit after a write" wrapping once.

Related: the action interfaces live in three places (separate ticket).

Found in a review of the Android app.

`StreamViewModel` implements `RepositoryActions`, `Capturing`, `StreamReading`, `StateLists`, `Timesheets`, `Activities`, `Overviews`, `Notes`, `ChangesActions`, `Configuring` and `WorkingTime`. Each method mostly forwards to `session.value?.x(..., Instant.now()) ?: X.Failed(NO_STREAM)`, sometimes followed by `written(id)`. `App` then takes about 13 parameters that are all this same object. **Proposal** - Give each concern its own small adapter over `Streamd` (or over `StreamSession` plus the clock and `RepositoryConnection.written`): states, timesheets, activities, notes, configuration, capture. - Hand `App` one holder of them (for example `AppActions`) instead of thirteen parameters. - Keep one view model for the lifecycle: the `StateFlow`s and `viewModelScope`. - Write the "no stream" and "commit after a write" wrapping once. Related: the action interfaces live in three places (separate ticket). Found in a review of the Android app.

agentic-developer added the

android

label

2026-10-25 17:21:35 +01:00

agentic-developer referenced this issue

2026-10-25 17:55:44 +01:00

Android app review: fixes, performance and cleanups #336