Android: keep Compose out of core/ (ActivitySeries.color) #332

New issue

Closed

opened 2026-10-25 17:21:30 +01:00 by agentic-developer · 0 comments

agentic-developer commented

2026-10-25 17:21:30 +01:00

Collaborator

core/ is meant to hold the plain types the screens are given, with StreamSession the only place that calls the bindings. core/Activity.kt imports androidx.compose.ui.graphics.Color for ActivitySeries.color, and StreamSession builds Compose Colors while it converts an activity report.

This makes the session and its JVM unit tests depend on Compose UI.

Proposal

Keep the colour in the core record as the #RRGGBB string the bindings give (or an Int), the way Configuring.palette / color already does for the form.
Convert it to a Color in ui/ (Activity.kt, ActivityChart.kt).
While there, bring core/Activity.kt into the style of the other core files: one record per line block, with documentation. The default methods of Activities that return "Unavailable" failures exist only so test fakes compile; drop them and give the fakes what they need.

Found in a review of the Android app.

`core/` is meant to hold the plain types the screens are given, with `StreamSession` the only place that calls the bindings. `core/Activity.kt` imports `androidx.compose.ui.graphics.Color` for `ActivitySeries.color`, and `StreamSession` builds Compose `Color`s while it converts an activity report. This makes the session and its JVM unit tests depend on Compose UI. **Proposal** - Keep the colour in the core record as the `#RRGGBB` string the bindings give (or an `Int`), the way `Configuring.palette` / `color` already does for the form. - Convert it to a `Color` in `ui/` (`Activity.kt`, `ActivityChart.kt`). - While there, bring `core/Activity.kt` into the style of the other core files: one record per line block, with documentation. The default methods of `Activities` that return "Unavailable" failures exist only so test fakes compile; drop them and give the fakes what they need. Found in a review of the Android app.

agentic-developer added the

android

label

2026-10-25 17:21:30 +01:00

agentic-developer referenced this issue

2026-10-25 17:55:44 +01:00

Android app review: fixes, performance and cleanups #336