Merge pull request #118 from dorny/java-junit-support-errors

Fix JUnit test-cases with error misclassified as passed test

dist/index.js

@@ -930,18 +930,24 @@ class JavaJunitParser {
         });
     }
     getTestCaseResult(test) {
-        if (test.failure)
+        if (test.failure || test.error)
             return 'failed';
         if (test.skipped)
             return 'skipped';
         return 'success';
     }
     getTestCaseError(tc) {
-        if (!this.options.parseErrors || !tc.failure) {
+        var _a;
+        if (!this.options.parseErrors) {
             return undefined;
         }
-        const failure = tc.failure[0];
+        // We process <error> and <failure> the same way
-        const details = failure._;
+        const failures = (_a = tc.failure) !== null && _a !== void 0 ? _a : tc.error;
+        if (!failures) {
+            return undefined;
+        }
+        const failure = failures[0];
+        const details = typeof (failure) === 'object' ? failure._ : failure;
         let filePath;
         let line;
         const src = this.exceptionThrowSource(details);
@@ -953,7 +959,7 @@ class JavaJunitParser {
             path: filePath,
             line,
             details,
-            message: failure.message
+            message: typeof (failure) === 'object' ? failure.message : undefined
         };
     }
     exceptionThrowSource(stackTrace) {

src/parsers/java-junit/java-junit-parser.ts

@@ -107,18 +107,24 @@ export class JavaJunitParser implements TestParser {
   }
 
   private getTestCaseResult(test: TestCase): TestExecutionResult {
-    if (test.failure) return 'failed'
+    if (test.failure || test.error) return 'failed'
     if (test.skipped) return 'skipped'
     return 'success'
   }
 
   private getTestCaseError(tc: TestCase): TestCaseError | undefined {
-    if (!this.options.parseErrors || !tc.failure) {
+    if (!this.options.parseErrors) {
       return undefined
     }
 
-    const failure = tc.failure[0]
+    // We process <error> and <failure> the same way
-    const details = failure._
+    const failures = tc.failure ?? tc.error
+    if (!failures) {
+      return undefined
+    }
+
+    const failure = failures[0]
+    const details = typeof failure === 'object' ? failure._ : failure
     let filePath
     let line
 
@@ -132,7 +138,7 @@ export class JavaJunitParser implements TestParser {
       path: filePath,
       line,
       details,
-      message: failure.message
+      message: typeof failure === 'object' ? failure.message : undefined
     }
   }
 

src/parsers/java-junit/java-junit-types.ts

@@ -33,7 +33,8 @@ export interface TestCase {
     name: string
     time: string
   }
-  failure?: Failure[]
+  failure?: string | Failure[]
+  error?: string | Failure[]
   skipped?: string[]
 }