Merge pull request #84 from Shazwazza/patch-1

Fixes #83 - parsing .NET duration without milliseconds throws error

__tests__/utils/parse-utils.test.ts

@@ -0,0 +1,37 @@
+import {parseNetDuration} from '../../src/utils/parse-utils'
+
+describe('parseNetDuration', () => {
+  it('returns 0 for 00:00:00', () => {
+    const ms = parseNetDuration('00:00:00')
+    expect(ms).toBe(0)
+  })
+
+  it('returns 0 for 00:00:00.0000000', () => {
+    const ms = parseNetDuration('00:00:00.0000000')
+    expect(ms).toBe(0)
+  })
+
+  it('returns 123 for 00:00:00.123', () => {
+    const ms = parseNetDuration('00:00:00.123')
+    expect(ms).toBe(123)
+  })
+
+  it('returns 12 * 1000 for 00:00:12', () => {
+    const ms = parseNetDuration('00:00:12')
+    expect(ms).toBe(12 * 1000)
+  })
+
+  it('returns 12 * 60 * 1000 for 00:12:00', () => {
+    const ms = parseNetDuration('00:12:00')
+    expect(ms).toBe(12 * 60 * 1000)
+  })
+
+  it('returns 12 * 60 * 60 * 1000 for 12:00:00', () => {
+    const ms = parseNetDuration('12:00:00')
+    expect(ms).toBe(12 * 60 * 60 * 1000)
+  })
+
+  it('throws when string has invalid format', () => {
+    expect(() => parseNetDuration('12:34:56 not a duration')).toThrowError(/^Invalid format/)
+  })
+})

dist/index.js

@@ -1799,8 +1799,7 @@ exports.formatTime = formatTime;
 Object.defineProperty(exports, "__esModule", ({ value: true }));
 exports.parseIsoDate = exports.parseNetDuration = void 0;
 function parseNetDuration(str) {
-    // matches dotnet duration: 00:00:00.0010000
-    const durationRe = /^(\d\d):(\d\d):(\d\d\.\d+)$/;
+    const durationRe = /^(\d\d):(\d\d):(\d\d(?:\.\d+)?)$/;
     const durationMatch = str.match(durationRe);
     if (durationMatch === null) {
         throw new Error(`Invalid format: "${str}" is not NET duration`);

src/utils/parse-utils.ts

@@ -1,6 +1,5 @@
 export function parseNetDuration(str: string): number {
-  // matches dotnet duration: 00:00:00.0010000
-  const durationRe = /^(\d\d):(\d\d):(\d\d\.\d+)$/
+  const durationRe = /^(\d\d):(\d\d):(\d\d(?:\.\d+)?)$/
   const durationMatch = str.match(durationRe)
   if (durationMatch === null) {
     throw new Error(`Invalid format: "${str}" is not NET duration`)