Reaction to PR feedback

This commit is contained in:
Ray Xu 2024-06-25 10:19:55 -07:00
parent 574868ab61
commit 1db430559c
16 changed files with 4133 additions and 4133 deletions

View file

@ -155,9 +155,9 @@ function getTestRunsReport(testRuns: TestRunResult[], options: ReportOptions): s
.map(tr => {
const time = formatTime(tr.time)
const name = tr.path
const passed = tr.passed > 0 ? `${tr.passed}${Icon.success}` : ''
const failed = tr.failed > 0 ? `${tr.failed}${Icon.fail}` : ''
const skipped = tr.skipped > 0 ? `${tr.skipped}${Icon.skip}` : ''
const passed = tr.passed > 0 ? `${tr.passed} ${Icon.success}` : ''
const failed = tr.failed > 0 ? `${tr.failed} ${Icon.fail}` : ''
const skipped = tr.skipped > 0 ? `${tr.skipped} ${Icon.skip}` : ''
return [name, passed, failed, skipped, time]
})
@ -207,9 +207,9 @@ function getSuitesReport(tr: TestRunResult, runIndex: number, options: ReportOpt
const skipLink = options.listTests === 'none' || (options.listTests === 'failed' && s.result !== 'failed')
const tsAddr = options.baseUrl + makeSuiteSlug(runIndex, suiteIndex).link
const tsNameLink = skipLink ? tsName : link(tsName, tsAddr)
const passed = s.passed > 0 ? `${s.passed}${Icon.success}` : ''
const failed = s.failed > 0 ? `${s.failed}${Icon.fail}` : ''
const skipped = s.skipped > 0 ? `${s.skipped}${Icon.skip}` : ''
const passed = s.passed > 0 ? `${s.passed} ${Icon.success}` : ''
const failed = s.failed > 0 ? `${s.failed} ${Icon.fail}` : ''
const skipped = s.skipped > 0 ? `${s.skipped} ${Icon.skip}` : ''
return [tsNameLink, passed, failed, skipped, tsTime]
})
)

View file

@ -6,9 +6,9 @@ export enum Align {
}
export const Icon = {
skip: ':warning:',
success: ':white_check_mark:',
fail: ':x:'
skip: '⚪', // ':white_circle:'
success: '✅', // ':white_check_mark:'
fail: '❌' // ':x:'
}
export function link(title: string, address: string): string {